Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared flow support #47

Merged
merged 3 commits into from
Nov 14, 2019
Merged

Shared flow support #47

merged 3 commits into from
Nov 14, 2019

Conversation

zkauker
Copy link
Contributor

@zkauker zkauker commented Nov 14, 2019

Unfortunately I didn't notice the #44 feature request by @tibers and I worked pretty much on the same. I added the support of Shared Flows based on the api_proxy and api_proxy_deployment resources.

As the code currently is pretty much copy-paste i would suggest to spend some time on consolidating the code base - I'm gonna open a new issue with my suggestions. However, if it's possible I'd be happy if you could create a new release with my PRs merged @zambien (I need these features in a project I'm working on right now).

Closes #44

@zambien
Copy link
Owner

zambien commented Nov 14, 2019

Thanks for another contribution!! Much appreciated!

@zambien zambien merged commit feb5e02 into zambien:master Nov 14, 2019
@zambien
Copy link
Owner

zambien commented Nov 14, 2019

@zkauker release has been created. Thanks for implementing this... I had always meant to but haven't built any shared flows myself. I would love to hear your suggestions on refactoring and improvement!

@zkauker
Copy link
Contributor Author

zkauker commented Nov 14, 2019

@zambien Yeey! Thank you very much for the super fast reaction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Shared Flows
2 participants