Skip to content

Commit

Permalink
vfio: platform: support No-IOMMU mode
Browse files Browse the repository at this point in the history
The vfio No-IOMMU mode was supported by this
'commit 03a76b6 ("vfio: Include No-IOMMU mode")',
but it only support vfio-pci.

Using vfio_iommu_group_get/put, but not iommu_group_get/put,
the platform devices can be exposed to userspace with
CONFIG_VFIO_NOIOMMU and the "enable_unsafe_noiommu_mode"
option enabled.

From 'commit 03a76b6 ("vfio: Include No-IOMMU mode")',
"This should make it very clear that this mode is not safe.
Additionally, CAP_SYS_RAWIO privileges are necessary to work
with groups and containers using this mode.  Groups making
use of this support are named /dev/vfio/noiommu-$GROUP and
can only make use of the special VFIO_NOIOMMU_IOMMU for the
container.  Use of this mode, specifically binding a device
without a native IOMMU group to a VFIO bus driver will taint
the kernel and should therefore not be considered supported."

Signed-off-by: Peng Fan <[email protected]>
Cc: Eric Auger <[email protected]>
Cc: Baptiste Reynal <[email protected]>
Cc: Alex Williamson <[email protected]>
Reviewed-by: Eric Auger <[email protected]>
Signed-off-by: Alex Williamson <[email protected]>
  • Loading branch information
MrVan authored and awilliam committed Jun 23, 2016
1 parent 33688ab commit 9698cbf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/vfio/platform/vfio_platform_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -561,15 +561,15 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,

vdev->device = dev;

group = iommu_group_get(dev);
group = vfio_iommu_group_get(dev);
if (!group) {
pr_err("VFIO: No IOMMU group for device %s\n", vdev->name);
return -EINVAL;
}

ret = vfio_add_group_dev(dev, &vfio_platform_ops, vdev);
if (ret) {
iommu_group_put(group);
vfio_iommu_group_put(group, dev);
return ret;
}

Expand All @@ -589,7 +589,7 @@ struct vfio_platform_device *vfio_platform_remove_common(struct device *dev)

if (vdev) {
vfio_platform_put_reset(vdev);
iommu_group_put(dev->iommu_group);
vfio_iommu_group_put(dev->iommu_group, dev);
}

return vdev;
Expand Down

0 comments on commit 9698cbf

Please sign in to comment.