Implement getMetadata for some more Passive scripts
#452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
reviewed
Jun 12, 2024
passive/Report non static sites.js
Outdated
| This indicates that this may not be a static site. | ||
| solution: > | ||
| If this is not a static site then ignore or disable this rule. | ||
| risk: high |
There was a problem hiding this comment.
I understand you've recreated what was previously here but ummm imho we are safe to change this
There was a problem hiding this comment.
I guess if it is changed that should be noted in the changelog
There was a problem hiding this comment.
I was thinking that too. Should I update it to info?
There was a problem hiding this comment.
Regarding the changelog, some names/descriptions/… were changed as well (not only in this PR), maybe add a generic entry saying that the scripts that now implement getMetadata() had their info revised?
thc202
reviewed
Jun 13, 2024
Update the following scripts to implement the `getMetadata()` function: - passive/google_api_keys_finder.js - passive/JavaDisclosure.js - passive/Report non static sites.js - passive/RPO.js - passive/s3.js Signed-off-by: ricekot <[email protected]>
ricekot
force-pushed
the
passive-scripts-metadata
branch
from
16d2c67 to
6851ba7
Compare
thc202
approved these changes
Jun 17, 2024
|
Thank you! |
kingthorin
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the following scripts to implement the
getMetadata()function:Part of #440.