Fix loop's statements copy #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ZestLoop to return the new list, when copying the statements, not the same list that's being copied, also, return an empty list instead of null when empty/null (does not require calling code to handle the null case). As part of the change the new list was renamed to not clash with the instance variable. Add test to assert the expected behaviour.
psiinon
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ZestLoop to return the new list, when copying the statements, not
the same list that's being copied, also, return an empty list instead of
null when empty/null (does not require calling code to handle the null
case). As part of the change the new list was renamed to not clash with
the instance variable.
Add test to assert the expected behaviour.