Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Doom walkthrough using the new walkthrough format #1456

Merged
merged 8 commits into from
Mar 21, 2023
Merged

Reorganize Doom walkthrough using the new walkthrough format #1456

merged 8 commits into from
Mar 21, 2023

Conversation

JasonvanBrackel
Copy link
Contributor

Description

Uses the new walkthrough format, and includes a new embedded YouTube video.

Related Issue

Partially Fixes #1377

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify
Copy link

netlify bot commented Mar 20, 2023

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 14c6391
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6419c6de11444400086b9bfe
😎 Deploy Preview https://deploy-preview-1456--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two tiny potential changes

docs/13-walkthroughs/2-deploying-doom.md Outdated Show resolved Hide resolved
docs/13-walkthroughs/2-deploying-doom.md Outdated Show resolved Hide resolved
docs/13-walkthroughs/2-deploying-doom.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@Racer159 Racer159 merged commit 4ac255f into zarf-dev:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing walkthrough cleanup
2 participants