Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for byte shuffle as a codec so that it can be used as a Zarr filter #273
Add support for byte shuffle as a codec so that it can be used as a Zarr filter #273
Changes from 27 commits
fd7adbb
bb912ec
99451ab
143c7f3
4aa207d
3356e3c
ebc01e0
5875c44
40b35b0
2db05b6
2592cc2
e0687d3
05ca79c
5789d13
51a9e36
49729f0
786cc4d
fdc06c8
2a5ae74
a22c390
382bb68
68eb615
cabff90
4850825
9733a51
06f380e
29036e9
edda78e
e92f1ec
26573c6
a520bfd
7567209
fcdf9a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this can fail, as it has no dependencies (like gzip)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I thought the same, not sure what is going on but the tests fail on all platforms except linux if I dont include the exception handling (e.g. https://github.com/zarr-developers/numcodecs/pull/273/checks?check_run_id=2091910819)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham do you have any advice on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored to separate cython code from python class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still has errors on platforms other than linux....