admin/enable-tests-for-windows-and-mac #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jakirkham <[email protected]>
7 tasks
|
|
|
Hurray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered during #273, MacOS and Windows builds weren't running the full test suite.
Couple of comments. Massive thanks to @hoefling for letting us know how to solve the problem. I have included a "Help from..." tag in the release. I hope that is okay, just want to credit you with the fix.
While these builds now run all defined tests (windows test log and mac test log) they do not run doctests. There were three errors that arose on the windows side of things when enabled -- different outputs from what was written as expected (all of which were dtype differences). Other than that, all good.
See comments above
tox -e py39passes locallytox -e docspasses locally