Apply repo-review suggestions #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 59 59
Lines 2332 2332
=======================================
Hits 2330 2330
Misses 2 2
|
DimitriPapadopoulos
force-pushed
the
repo-review
branch
6 times, most recently
from
a21fa08 to
d8bc0d1
Compare
DimitriPapadopoulos
force-pushed
the
repo-review
branch
6 times, most recently
from
c1d29b7 to
30d1436
Compare
DimitriPapadopoulos
force-pushed
the
repo-review
branch
4 times, most recently
from
8a87af5 to
4b7cd64
Compare
|
Thanks, @DimitriPapadopoulos, but would you also be willing to apply this to the |
|
There is no |
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
4b7cd64 to
46e9cc4
Compare
|
🤦 Apologies, @DimitriPapadopoulos. You are of course correct. Sorry for the noise. |
DimitriPapadopoulos
force-pushed
the
repo-review
branch
4 times, most recently
from
2c8c2d5 to
2bd85be
Compare
dstansby
approved these changes
Sep 16, 2024
DimitriPapadopoulos
force-pushed
the
repo-review
branch
3 times, most recently
from
b8c488b to
85249db
Compare
DimitriPapadopoulos
force-pushed
the
repo-review
branch
2 times, most recently
from
f5c15de to
a1eec88
Compare
DimitriPapadopoulos
force-pushed
the
repo-review
branch
4 times, most recently
from
fe7ebec to
b7b21b4
Compare
PP304: Sets the log level in pytest log_cli_level should be set. This will allow logs to be displayed on failures.
PP305: Specifies xfail_strict xfail_strict should be set. You can manually specify if a check should be strict when setting each xfail.
PP306: Specifies strict config --strict-config should be in addopts = [...]. This forces an error if a config setting is misspelled. PP307: Specifies strict markers --strict-markers should be in addopts = [...]. This forces all markers to be specified in config, avoiding misspellings. PP308: Specifies useful pytest summary An explicit summary flag like -ra should be in addopts = [...] (print summary of all fails/errors).
PGH004 Use specific rule codes when using `noqa` PGH004 Use specific rule codes when using `ruff: noqa`
Apply ruff rule RUF012: RUF012 Mutable class attributes should be annotated with `typing.ClassVar` Disable ruff rule RUF001
B007 Loop control variable not used within loop body
B028 No explicit `stacklevel` keyword argument found
B904 Within an `except` clause, raise exceptions with `raise ... from err` or
`raise ... from None` to distinguish them from errors in exception handling
B905 `zip()` without an explicit `strict=` parameter
Co-authored-by: David Stansby <[email protected]>
PC100: Has pre-commit-hooks Must have https://github.com/pre-commit/pre-commit-hooks repo in .pre-commit-config.yaml
ISC001 Implicitly concatenated string literals on one line ISC003 Explicitly concatenated string should be implicitly concatenated
FURB163 Prefer `math.log10`/`math.log2` over `math.log` with a redundant base
'pkgutil.find_loader' is deprecated and slated for removal in Python 3.14; use importlib.util.find_spec() instead
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
b7b21b4 to
bf0ffae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://learn.scientific-python.org/development/guides/repo-review/?repo=zarr-developers%2Fnumcodecs&branch=main
TODO: