Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with zarr 3 beta #597

Merged

Conversation

mpiannucci
Copy link
Contributor

This syncs the zarr3 wrapper with the latest zarr beta.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@jhamman jhamman requested a review from normanrz October 15, 2024 20:05
@jhamman
Copy link
Member

jhamman commented Oct 15, 2024

@normanrz - we (@mpiannucci and the crew at Earthmover) are interested in helping finish off #524. Do you have the bandwidth to review some work in this space?

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.29%. Comparing base (b75e41e) to head (d01669b).

Files with missing lines Patch % Lines
numcodecs/zarr3.py 50.00% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           zarr3-codecs     #597      +/-   ##
================================================
- Coverage         94.31%   91.29%   -3.02%     
================================================
  Files                61       61              
  Lines              2584     2586       +2     
================================================
- Hits               2437     2361      -76     
- Misses              147      225      +78     
Files with missing lines Coverage Δ
numcodecs/zarr3.py 57.71% <50.00%> (+0.48%) ⬆️

... and 3 files with indirect coverage changes

@normanrz normanrz merged commit a4cf7ad into zarr-developers:zarr3-codecs Oct 16, 2024
18 of 24 checks passed
@mpiannucci mpiannucci deleted the zarr3-codecs-beta-sync branch October 16, 2024 13:00
normanrz added a commit that referenced this pull request Nov 8, 2024
* import zarr-python#1839

* pep8

* remove try/catch

* pep8

* update to latest zarr-python interfaces

* flake

* add zarr-python to ci

* fix import

* tests

* fixes

* skip zarr3 tests on older python versions

* ruff

* add zfpy and pcodec

* remove zarr from dependencies

* change prefix

* fixes for ci

* fix for tests

* pr feedback

* Sync with zarr 3 beta (#597)

* Sync with zarr 3 beta

* Update zarr version in ci

* dont install zarr python 3 in workflows running 3.10

* Update numcodecs/tests/test_zarr3.py

Co-authored-by: David Stansby <[email protected]>

* moves zarr3 to private module, adds test for zarr-python2 installs

* add typing_extensions as dep

* tests

* importorskip minversion

* ci install

* drop zarr 2 in ci

* no zarr2 + make zarr3 a public module

* pre-commit

* fixes?

* fix validate

* fix pcodec test

* fix pcodec test

* codecov

* codecov

* fix error match

* codecov

* codecov

* coverage

* wip docs

* docs and renames all codecs

* docs

* new zarr beta

* no zfpy for macos-14

* xfail

* rm dead code

* Update .github/workflows/ci.yaml

Co-authored-by: David Stansby <[email protected]>

* debug rtd

* debug ci

* Filter warnings in zarr3 tests

* Fix warning ignore

* pr feedback

---------

Co-authored-by: Matthew Iannucci <[email protected]>
Co-authored-by: David Stansby <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants