-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor UX improvement: Add the UnknownCodecError
.
#689
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 62 63 +1
Lines 2749 2755 +6
=======================================
+ Hits 2741 2747 +6
Misses 8 8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very 👍 doing this, thanks for the PR. I left a suggestion for the test, and also I'm a bit on the fence about ValueError
, so let me know your thoughts there.
Co-authored-by: David Stansby <[email protected]>
See zarr-developers/zarr-python#2508 for context.
Since
numcodecs
supports registering custom codecs in downstream libraries, there can be situations where the environment in which data was encoded is not the same as the environment in which the data is decoded (e.g. opening a Zarr archive that was created in a different environment). This can lead to missing codecs.It would be a nice UX improvement if you catch that error and can offer codec specific solutions.
This change would enable something like:
TODO: