Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell codespell to skip fixture / fix pre-commit #1197

Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 17, 2022

This will avoid this kind of warnings with codespell 2.2.2:

WARNING: Decoding file using encoding=utf-8 failed: fixture/8/0/11
WARNING: Trying next encoding iso-8859-1

Seen in:
https://results.pre-commit.ci/run/github/48049137/1666036569.rj425j-vQKyvNbJ0CUHdcQ

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@Saransh-cpp
Copy link
Contributor

Maybe we can also get rid of the hard python 3.9 requirement following @mzjp2's advice?

@DimitriPapadopoulos
Copy link
Contributor Author

I guess I can change python3.9 to python3 in this line:

default_language_version:
python: python3.9

I can do that in a different merge request - to avoid completely rewriting this one.

@jakirkham
Copy link
Member

It's ok if we want to lump these altogether. Maybe we can retitle the PR to capture that

This will avoid this kind of warnings:
	WARNING: Decoding file using encoding=utf-8 failed: fixture/8/0/11
	WARNING: Trying next encoding iso-8859-1

Seen in:
https://results.pre-commit.ci/run/github/48049137/1666036569.rj425j-vQKyvNbJ0CUHdcQ
@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Oct 18, 2022

I added a second commit to remove the hard python3.9 requirement.

Now pre-commit works on my workstation:

$ pre-commit run codespell
codespell............................................(no files to check)Skipped
$ 

@DimitriPapadopoulos DimitriPapadopoulos changed the title Tell codespell to skip fixture Tell codespell to skip fixture / fix pre-commit Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1197 (f11b449) into main (e8f6fef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1197   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files          35       35           
  Lines       14136    14135    -1     
=======================================
- Hits        14135    14134    -1     
  Misses          1        1           
Impacted Files Coverage Δ
zarr/util.py 100.00% <0.00%> (ø)

@jakirkham jakirkham merged commit 361ca77 into zarr-developers:main Oct 18, 2022
@jakirkham
Copy link
Member

Thanks @DimitriPapadopoulos! 🙏

@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell-skip-fixture branch October 18, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants