Create a Base store class for Zarr Store. #612
Conversation
|
May want to write a store "wrapper", that handle usual mutable mapping and offer the right methods. |
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
========================================
Coverage 99.93% 99.94%
========================================
Files 26 28 +2
Lines 9945 10307 +362
========================================
+ Hits 9939 10301 +362
Misses 6 6
|
zarr/storage.py
Outdated
| # def keys() | ||
| # def items() | ||
| # def values() | ||
| # def get |
Carreau
force-pushed
the
base-store
branch
2 times, most recently
from
01a68d5 to
0437842
Compare
Carreau
force-pushed
the
base-store
branch
2 times, most recently
from
14392e9 to
19fe17c
Compare
Unconditionally close store in tests. All the tested stores should now have a `close()` method we can call and will be no-op if the stores do not need closing. Turn UserWarnings into errors And turn then back into only warnings into relevant tests. This ensure that we are not using deprecated functionalities, except when testing for it. initially based on 318eddcd, and later 1249f35 and 0f89a96
|
@joshmoore test should be passing, only a rebase and some cleanup might still be necessary after the rebase to get coverage up to 100%. Do you want me to fork master into a dev branch and target that for a dev branch ? |
@Carreau, I didn't receive any objections to considering the mainline a pre-release while you get these branches in. Only requirement from my side would be to get 2.7.0 out the door. If we need a quick 2.7.x before you're done merging, then that would need to be from a stable branch. |
|
Having a think last night, what would everyone say to having this be the base for a |
|
Closing in favor of #789 |
In progress,
All existing stores in zarr-python now inherit from this; and thus all the test stop testing for a
close()method and call it unconditionally.The base store is a bit more strict in what it accepts than subclasses (only allow strings), as it is generally safer for the superclass to be stricter as anything that works with superclass will work with subclass, but the opposite is untrue.
TODO: