Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circumvent Codecov's legitimate complaint without resorting to pragma #823

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Circumvent Codecov's legitimate complaint without resorting to pragma #823

merged 5 commits into from
Aug 25, 2021

Conversation

benjaminhwilliams
Copy link
Contributor

@benjaminhwilliams benjaminhwilliams commented Aug 24, 2021

Codecov recognises that we aren't testing with fsspec. Perhaps it is less picky if we use pytest.param to parametrise the tests.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Codecov recognises that we aren't testing with fsspec.  Perhaps it is
less picky if we use pytest.param to parametrise the tests.
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #823 (b558e62) into master (4b03dfe) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          31       31           
  Lines       10606    10606           
=======================================
  Hits        10600    10600           
  Misses          6        6           
Impacted Files Coverage Δ
zarr/tests/test_dim_separator.py 100.00% <100.00%> (ø)

@benjaminhwilliams
Copy link
Contributor Author

As promised in #821 (comment), this is now ready for review.

Apologies that my silly typo incurred an extra round of CI checks, redundantly chewing through more electrons than was necessary.

@joshmoore
Copy link
Member

redundantly chewing through more electrons than was necessary.

Heh. We need a CO2 counter per PR (and/or [skip ci])

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the increase in sanity!

@joshmoore joshmoore merged commit acf6828 into zarr-developers:master Aug 25, 2021
@benjaminhwilliams benjaminhwilliams deleted the cheat-codecov-fsspec branch August 25, 2021 07:02
@jakirkham
Copy link
Member

Ah good catch. Thanks for adding this Ben! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants