-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circumvent Codecov's legitimate complaint without resorting to pragma #823
Circumvent Codecov's legitimate complaint without resorting to pragma #823
Conversation
Codecov recognises that we aren't testing with fsspec. Perhaps it is less picky if we use pytest.param to parametrise the tests.
Codecov Report
@@ Coverage Diff @@
## master #823 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 31 31
Lines 10606 10606
=======================================
Hits 10600 10600
Misses 6 6
|
As promised in #821 (comment), this is now ready for review. Apologies that my silly typo incurred an extra round of CI checks, redundantly chewing through more electrons than was necessary. |
Heh. We need a CO2 counter per PR (and/or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the increase in sanity!
Ah good catch. Thanks for adding this Ben! 😄 |
Codecov recognises that we aren't testing with
fsspec
. Perhaps it is less picky if we usepytest.param
to parametrise the tests.TODO: