Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use date format from regional settings #98

Merged
merged 1 commit into from
May 9, 2019

Conversation

igitur
Copy link
Contributor

@igitur igitur commented Mar 20, 2019

Implements simple date time format parser to break up the date format into its parts and implement it in the DateTimeDragControl.

@igitur
Copy link
Contributor Author

igitur commented May 9, 2019

Let me know if I should explain in more detail what this PR, and the date format parser does.

…ement simple date format parser in order to split date format into parts.
@igitur igitur force-pushed the use-thread-dateformat branch from 989380b to 311def2 Compare May 9, 2019 13:39
@zarunbal
Copy link
Owner

zarunbal commented May 9, 2019

Thanks for adapting / updating your PR to the changes. I'll have a look into it soon (Hopefully that I have some more free time). I currently try to finish the Release pipeline so I have less work to release a new version.

@zarunbal zarunbal merged commit 65332a5 into zarunbal:Development May 9, 2019
@zarunbal
Copy link
Owner

zarunbal commented May 9, 2019

Again thanks for your contribution! It would be great if you could add some unit tests at least for the non gui parts, by time.

@igitur
Copy link
Contributor Author

igitur commented May 17, 2019

Sure, I'll add unit tests later.

@igitur igitur deleted the use-thread-dateformat branch May 17, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants