Remove individual field references in favour of a simplified "global" reference for all coordinates #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
pascalzauberzeug
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
The changes seem fine to me, but I think @LukasBaecker can provide more inside
|
The test was successful. Including changing the reference point -> a test field created before stayed where it was created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the handling of coordinates by replacing the per-field geo reference a global reference which is set once and never changes. This simplifies the code a lot and is less error-prone.
The reference can be changed by the press of a button in the Field Planner. It takes the current position of the robot as new reference and restarts the system (because all cartesian coordinates floating in memory needs to be recalculated according to the new reference point).
ToDos