Introduce pre-commit hooks

.github/zip_content.txt

@@ -10,4 +10,4 @@ flash.py
 monitor.py
 README.md
 requirements.txt
-LICENSE
+LICENSE

.gitignore

@@ -8,4 +8,4 @@ sdkconfig
 owl_executable
 config.txt
 *.lock
-.venv
+.venv

.pre-commit-config.yaml

@@ -0,0 +1,12 @@
+default_install_hook_types:
+  - pre-commit
+  - pre-push
+
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v5.0.0
+    hooks:
+      - id: trailing-whitespace
+      - id: end-of-file-fixer
+      - id: check-merge-conflict
+      - id: double-quote-string-fixer

.syncignore

@@ -3,4 +3,4 @@ __pycache__/
 .DS_Store
 *.tmp
 .env
-.venv
+.venv

backtrace.sh

@@ -7,6 +7,6 @@ then
     exit
 fi
 
-addr2line=~/esp/esp-tools_4.2/tools/xtensa-esp32-elf/esp-2020r3-8.4.0/xtensa-esp32-elf/bin/xtensa-esp32-elf-addr2line 
+addr2line=~/esp/esp-tools_4.2/tools/xtensa-esp32-elf/esp-2020r3-8.4.0/xtensa-esp32-elf/bin/xtensa-esp32-elf-addr2line
 addresses=$@
 $addr2line -e build/lizard.elf $addresses

examples/ota_example/main.py

@@ -26,10 +26,10 @@ def ota_binary_verify(request: Request) -> Response:
         verify_bin_str = os.path.basename(verify_bin).replace('.bin', '').replace('lizard', '').replace('-', '')
         if verify_bin_str is None:
             log.push('No "Lizard" binary found. But connection established')
-            return Response("No Lizard")
-        if verify_bin_str == "":
+            return Response('No Lizard')
+        if verify_bin_str == '':
             log.push('Binary without version found')
-            return Response("Unknown version")
+            return Response('Unknown version')
         response = Response(verify_bin_str)
         log.push(f'Send response: {verify_bin_str}')
         return response

examples/ros/docker.sh

@@ -26,7 +26,7 @@ do
             docker build --tag $name . || exit ;;
         r | run)
             docker run -it $args $name || exit ;;
-        s | shell)                     
+        s | shell)
             docker run -it $args $name /bin/bash || exit ;;
         l | log | logs)
             docker logs -f --tail 100 $name || exit ;;

main/.gitignore

@@ -1 +1 @@
-parser.h
+parser.h

main/compilation/action.h

@@ -8,4 +8,4 @@ using Action_ptr = std::shared_ptr<Action>;
 class Action {
 public:
     virtual bool run() = 0;
-};
+};

main/compilation/await_condition.cpp

@@ -6,4 +6,4 @@ AwaitCondition::AwaitCondition(const ConstExpression_ptr condition)
 
 bool AwaitCondition::run() {
     return this->condition->evaluate_boolean();
-}
+}

main/compilation/await_condition.h

@@ -9,4 +9,4 @@ class AwaitCondition : public Action {
 
     AwaitCondition(const ConstExpression_ptr condition);
     bool run() override;
-};
+};

main/compilation/await_routine.cpp

@@ -14,4 +14,4 @@ bool AwaitRoutine::run() {
         this->is_waiting = false;
     }
     return can_proceed;
-}
+}

main/compilation/await_routine.h

@@ -12,4 +12,4 @@ class AwaitRoutine : public Action {
 
     AwaitRoutine(const Routine_ptr routine);
     bool run() override;
-};
+};

main/compilation/method_call.cpp

@@ -7,4 +7,4 @@ MethodCall::MethodCall(const Module_ptr module, const std::string method_name, c
 bool MethodCall::run() {
     this->module->call_with_shadows(this->method_name, this->arguments);
     return true;
-}
+}

main/compilation/method_call.h

@@ -14,4 +14,4 @@ class MethodCall : public Action {
 
     MethodCall(const Module_ptr module, const std::string method_name, const std::vector<ConstExpression_ptr> arguments);
     bool run() override;
-};
+};

main/compilation/property_assignment.cpp

@@ -7,4 +7,4 @@ PropertyAssignment::PropertyAssignment(const Module_ptr module, const std::strin
 bool PropertyAssignment::run() {
     this->module->write_property(this->property_name, this->expression);
     return true;
-}
+}

main/compilation/property_assignment.h

@@ -12,4 +12,4 @@ class PropertyAssignment : public Action {
 
     PropertyAssignment(const Module_ptr module, const std::string property_name, const ConstExpression_ptr expression);
     bool run() override;
-};
+};

main/compilation/routine.h

@@ -17,4 +17,4 @@ class Routine {
     bool is_running() const;
     void start();
     void step();
-};
+};

main/compilation/routine_call.cpp

@@ -6,4 +6,4 @@ RoutineCall::RoutineCall(const Routine_ptr routine) : routine(routine) {
 bool RoutineCall::run() {
     this->routine->start();
     return true;
-}
+}

main/compilation/routine_call.h

@@ -9,4 +9,4 @@ class RoutineCall : public Action {
 
     RoutineCall(const Routine_ptr routine);
     bool run() override;
-};
+};

main/compilation/rule.h

@@ -13,4 +13,4 @@ class Rule {
     const ConstExpression_ptr condition;
     const Routine_ptr routine;
     Rule(const ConstExpression_ptr condition, const Routine_ptr routine);
-};
+};

main/compilation/variable_assignment.cpp

@@ -7,4 +7,4 @@ VariableAssignment::VariableAssignment(const Variable_ptr variable, const ConstE
 bool VariableAssignment::run() {
     this->variable->assign(this->expression);
     return true;
-}
+}

main/compilation/variable_assignment.h

@@ -11,4 +11,4 @@ class VariableAssignment : public Action {
 
     VariableAssignment(const Variable_ptr variable, const ConstExpression_ptr expression);
     bool run() override;
-};
+};

main/component.mk

@@ -5,4 +5,4 @@
 
 CXXFLAGS += -std=c++17
 
-COMPONENT_SRCDIRS := . compilation modules utils
+COMPONENT_SRCDIRS := . compilation modules utils

main/modules/BNO055ESP32.cpp

@@ -845,4 +845,4 @@ void BNO055::stop() {
 #ifndef BNO055_DEBUG_OFF
     ESP_LOGD(BNO055_LOG_TAG, "Destroyed");
 #endif
-}
+}

main/modules/BNO055ESP32.h

@@ -729,4 +729,4 @@ class BNO055 {
     void disableInterrupt(uint8_t flag);
 };
 
-#endif
+#endif

main/modules/core.cpp

@@ -199,4 +199,4 @@ std::string Core::get_output() const {
 
 void Core::keep_alive() {
     this->last_message_millis = millis();
-}
+}

main/modules/core.h

@@ -26,4 +26,4 @@ class Core : public Module {
     void set(std::string property_name, double value);
     std::string get_output() const override;
     void keep_alive();
-};
+};

main/modules/d1_motor.h

@@ -31,4 +31,4 @@ class D1Motor : public Module, public std::enable_shared_from_this<D1Motor> {
     void profile_position(const int32_t position);
     void profile_velocity(const int32_t velocity);
     void stop();
-};
+};

main/modules/dunker_motor.cpp

@@ -138,4 +138,4 @@ void DunkerMotor::speed(const double speed) {
 
 double DunkerMotor::get_speed() {
     return this->properties.at("speed")->number_value;
-}
+}

main/modules/dunker_wheels.h

@@ -12,4 +12,4 @@ class DunkerWheels : public Module {
     DunkerWheels(const std::string name, const DunkerMotor_ptr left_motor, const DunkerMotor_ptr right_motor);
     void step() override;
     void call(const std::string method_name, const std::vector<ConstExpression_ptr> arguments) override;
-};
+};

main/modules/input.cpp

@@ -73,4 +73,4 @@ void McpInput::set_pull_mode(const gpio_pull_mode_t mode) const {
         throw std::runtime_error("pulldown mode is not supported");
     }
     this->mcp->set_pullup(this->number, mode == GPIO_PULLUP_ONLY);
-}
+}

main/modules/input.h

@@ -40,4 +40,4 @@ class McpInput : public Input {
 public:
     McpInput(const std::string name, const Mcp23017_ptr mcp, const uint8_t number);
     bool get_level() const override;
-};
+};

main/modules/linear_motor.h

@@ -57,4 +57,4 @@ class McpLinearMotor : public LinearMotor {
                    const uint8_t move_out,
                    const uint8_t end_in,
                    const uint8_t end_out);
-};
+};

main/modules/odrive_motor.h

@@ -37,4 +37,4 @@ class ODriveMotor : public Module, public std::enable_shared_from_this<ODriveMot
     void position(const double position, const double speed, const double acceleration) override;
     double get_speed() override;
     void speed(const double speed, const double acceleration) override;
-};
+};

main/modules/odrive_wheels.h

@@ -17,4 +17,4 @@ class ODriveWheels : public Module {
     ODriveWheels(const std::string name, const ODriveMotor_ptr left_motor, const ODriveMotor_ptr right_motor);
     void step() override;
     void call(const std::string method_name, const std::vector<ConstExpression_ptr> arguments) override;
-};
+};

main/modules/output.h

@@ -36,4 +36,4 @@ class McpOutput : public Output {
 
 public:
     McpOutput(const std::string name, const Mcp23017_ptr mcp, const uint8_t number);
-};
+};

main/modules/proxy.h

@@ -15,4 +15,4 @@ class Proxy : public Module {
           const std::vector<ConstExpression_ptr> arguments);
     void call(const std::string method_name, const std::vector<ConstExpression_ptr> arguments) override;
     void write_property(const std::string property_name, const ConstExpression_ptr expression, const bool from_expander) override;
-};
+};

main/modules/rmd_motor.h

@@ -41,4 +41,4 @@ class RmdMotor : public Module, public std::enable_shared_from_this<RmdMotor> {
     double get_position() const;
     double get_speed() const;
     bool set_acceleration(const uint8_t index, const uint32_t acceleration);
-};
+};

main/modules/roboclaw.h

@@ -220,4 +220,4 @@ class RoboClaw : public Module {
     uint32_t Read4(uint8_t cmd, bool *valid);
     uint16_t Read2(uint8_t cmd, bool *valid);
     uint8_t Read1(uint8_t cmd, bool *valid);
-};
+};

main/parser.h

@@ -8194,4 +8194,3 @@ static void left_right_operand_slots_lookup(uint32_t rule, uint32_t *left, uint3
     }
 }
 #endif
-

main/storage.h

@@ -16,4 +16,4 @@ class Storage {
     static void print_startup(const std::string substring = "");
     static void save_startup();
     static void clear_nvs();
-};
+};

main/utils/string_utils.cpp

@@ -27,4 +27,4 @@ int csprintf(char *buffer, size_t buffer_len, const char *format, ...) {
         throw std::runtime_error("buffer too small");
 
     return num_chars;
-}
+}

main/utils/string_utils.h

@@ -6,4 +6,4 @@ std::string cut_first_word(std::string &msg, char delimiter = ' ');
 
 bool starts_with(const std::string haystack, const std::string needle);
 
-int csprintf(char *buffer, size_t buffer_len, const char *format, ...);
+int csprintf(char *buffer, size_t buffer_len, const char *format, ...);

main/utils/timing.cpp

@@ -21,4 +21,4 @@ unsigned long millis_since(const unsigned long time) {
 
 unsigned long micros_since(const unsigned long time) {
     return micros() - time;
-}
+}

main/utils/timing.h

@@ -8,4 +8,4 @@ unsigned long int micros();
 unsigned long int millis();
 
 unsigned long millis_since(const unsigned long time);
-unsigned long micros_since(const unsigned long time);
+unsigned long micros_since(const unsigned long time);