Update owl without hotfixes #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JensOgorek
commented
Jan 9, 2025
| @@ -11,6 +11,6 @@ idf_component_register( | |||
| INCLUDE_DIRS "." "compilation" "modules" "utils" "${CMAKE_BINARY_DIR}/generated" | |||
| REQUIRES driver esp_wifi esp_timer efuse lwip esp_event esp_netif esp_adc esp32-ble-command esp32-zeug esp32-serial-flasher app_update esp_driver_uart esp_https_ota spi_flash | |||
| ) | |||
|
|
|||
| add_compile_definitions(OWL_TOKEN_RUN_LENGTH=256) | |||
There was a problem hiding this comment.
I tried to just add the #define OWL_TOKEN_RUN_LENGTH 256 to the main.cpp before loading parser.h, but it did get ignored.
I found two ways that work:
- adding the
#define OWL_TOKEN_RUN_LENGTH 256to parser.c - adding
add_compile_definitions(OWL_TOKEN_RUN_LENGTH=256)to the CMakeLists.txt
I chose the latter for now.
|
Also, I tried the new error code with memory allocation, that works as well. |
falkoschindler
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates owl to the current main version without the need for any hotfixes.