Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More information on storage failure #43

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

SeaTechRC
Copy link
Contributor

Hello,

As of now there is no exact explanation for when the storage module failed to write to flash.
In order to be able to differentiate between different failure modes, the error message includes the esp_err_t string in the sotrage class.

@rodja rodja requested a review from falkoschindler June 18, 2024 17:50
@rodja rodja added the enhancement New feature or request label Jun 18, 2024
@rodja rodja added this to the 0.1.12 milestone Jun 18, 2024
Copy link
Collaborator

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, @SeaTechRC!

The inline assignment if ((err = ...) != ESP_OK) { is a bit unconventional, but fine with me.

Assuming you already compiled and tested the implementation, I happily approve the PR. 👍🏻

@falkoschindler falkoschindler self-requested a review June 21, 2024 18:43
Copy link
Collaborator

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compiled it myself and noticed an error due to declaring err but using error. This was easy to fix.
But now I feel like testing it on a real ESP at least once before merging.

@falkoschindler
Copy link
Collaborator

Ok, I erased the storage of an ESP using esptool.py erase_flash and - after flashing and restarting - got the expected error message including the error name "ESP_ERR_NVS_NOT_FOUND":

error while loading startup script: could not peek storage storage.num_chunks (ESP_ERR_NVS_NOT_FOUND)

@falkoschindler falkoschindler merged commit 1b1adb1 into zauberzeug:main Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants