Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: complete refactoring #398

Merged
merged 12 commits into from
Jul 26, 2024
Merged

images: complete refactoring #398

merged 12 commits into from
Jul 26, 2024

Conversation

zbycz
Copy link
Owner

@zbycz zbycz commented Jul 5, 2024 •
edited
Loading

followups:

  • mapillary on point is added twice (resulting in twice same record in sameImageResolvedAlsoFrom)
  • on photos wider than featurepanel (responsive) the InfoIcon is hidden + looks wierd
  • show LoadingSkeleton after 300ms
  • dont use type { def, image } - must be composed as image.def
  • test mergeResultFn()
multiple images scrolled + panellum 360 viewer
image image

Multiple services resolving to one Image

image

@vercel Vercel
Copy link

vercel bot commented Jul 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Jul 26, 2024 3:44pm

@Dlurak
Copy link
Collaborator

Dlurak commented Jul 6, 2024

Hi,
css supports scroll snapping which might be good for the image slider :)

Base automatically changed from new-drawer to master July 6, 2024 15:32
@zbycz
Copy link
Owner Author

zbycz commented Jul 7, 2024

Hi, css supports scroll snapping which might be good for the image slider :)

HI @Dlurak , thanks - i tested the snapping (this example), but it feels more fluent with just scrollable pane. Lets experiment in a followup 👍

@zbycz zbycz changed the title images: redesign + deprecate FeatureImage images: complete refactoring + use ImageSlider Jul 18, 2024
@zbycz zbycz changed the title images: complete refactoring + use ImageSlider images: complete refactoring Jul 26, 2024
@zbycz zbycz marked this pull request as ready for review July 26, 2024 15:31
@zbycz zbycz enabled auto-merge (squash) July 26, 2024 15:43
@zbycz zbycz merged commit cadb229 into master Jul 26, 2024
2 checks passed
@zbycz zbycz deleted the image-defs branch July 26, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zbycz @Dlurak