Remove selector_map from pinned verification key and remove VerificationKey serialization #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebfull
added
M-verifier-compatibility
ebfull
force-pushed
the
reconstruct-selectors
branch
from
20da7e8 to
32dd524
Compare
ebfull
force-pushed
the
reconstruct-selectors
branch
from
32dd524 to
f46d777
Compare
str4d
added a commit
to zcash/orchard
that referenced
this pull request
Mar 22, 2022
The change to the pinned circuit description is due to removing the unnecessary `selector_map` pin in zcash/halo2#521. This invalidates previous proofs due to changing Fiat-Shamir transcript initialization).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two problems this PR is addressing.
VerifyingKey#449) So, this PR removes it for the time being until we can write a working implementation later.selector_mapwhich isn't used anywhere and doesn't describe anything that isn't already fully determined by the rest of the key. We want to remove this from the pinned verification key so that we don't have to reconstruct this in the future. (Note that this makes proofs incompatible with previous versions because it changes Fiat-Shamir transcript initialization.)