Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More crate updates #127

Merged
merged 5 commits into from
Sep 18, 2019
Merged

More crate updates #127

merged 5 commits into from
Sep 18, 2019

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Sep 12, 2019

Includes a fix for a bellman compile bug introduced in #104.

@str4d str4d added the bug label Sep 12, 2019
@str4d str4d added this to the v0.1.0 milestone Sep 12, 2019
@str4d str4d requested review from ebfull and Eirik0 September 12, 2019 18:40
@codecov-io
Copy link

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #127   +/-   ##
======================================
  Coverage    56.2%   56.2%           
======================================
  Files          43      43           
  Lines        6120    6120           
======================================
  Hits         3440    3440           
  Misses       2680    2680
Impacted Files Coverage Δ
bellman/src/gadgets/test/mod.rs 66.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6fbfd...28dcc1c. Read the comment docs.

source = "registry+https://github.com/rust-lang/crates.io-index"

[[package]]
name = "crossbeam"
version = "0.3.2"
version = "0.7.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to see if we can rely on just one of these subcrates of crossbeam rather than crossbeam and all of these other crates. (Not blocking.)

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d str4d removed the request for review from Eirik0 September 18, 2019 15:44
@str4d str4d merged commit d2da9cf into zcash:master Sep 18, 2019
@str4d str4d deleted the more-crate-updates branch September 18, 2019 15:44
This was referenced Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants