Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unified Address parser structural checks #416

Merged
merged 10 commits into from
Jul 12, 2021
Merged

Add Unified Address parser structural checks #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
01a8dba
zcash_address: Add a Typecode enum
str4d Jul 12, 2021
cd94b41
zcash_address: Introduce UA-specific parser error type
str4d Jul 12, 2021
7708b27
zcash_address: Enforce UA structural validity checks
str4d Jul 12, 2021
b175b9b
zcash_address: Use preference ordering for Receivers
str4d Jul 12, 2021
384af07
zcash_address: Add `unified::Address::receivers{_as_parsed}` APIs
str4d Jul 12, 2021
060a15e
zcash_address: Enable constructing a unified::Address from Vec<Receiver>
str4d Jul 12, 2021
77d1f0c
zcash_address: Invert Typecode::is_shielded to Typecode::is_transparent
str4d Jul 12, 2021
478625f
zcash_address: Add UA test cases for truncation and invalid padding
str4d Jul 12, 2021
8527dcb
zcash_address: Remove outdated unified::Receiver documentation
str4d Jul 12, 2021
b875f6c
zcash_address: Fix clippy lint by using matches! macro
str4d Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions components/zcash_address/src/encoding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,25 @@ pub enum ParseError {
InvalidEncoding,
/// The string is not a Zcash address.
NotZcash,
/// Errors specific to unified addresses.
Unified(unified::ParseError),
}

impl From<unified::ParseError> for ParseError {
fn from(e: unified::ParseError) -> Self {
match e {
unified::ParseError::InvalidEncoding => Self::InvalidEncoding,
_ => Self::Unified(e),
}
}
}

impl fmt::Display for ParseError {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
ParseError::InvalidEncoding => write!(f, "Invalid encoding"),
ParseError::NotZcash => write!(f, "Not a Zcash address"),
ParseError::Unified(e) => e.fmt(f),
}
}
}
Expand Down
Loading