Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orchard key components #40
Orchard key components #40
Changes from 22 commits
f077979
ceac39d
eaa7158
2750170
5772c71
a61be5d
71542f7
9455158
57c6492
cfaa61a
26701c3
307787e
bf5fb7a
cef44f5
2462bb2
f7cad77
e98f324
e0b40cb
46bf89c
3c8befa
8e55b46
e041726
42ea809
861eec1
51fd94d
05e86a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An idea:
From/Into
's alongside the more descriptive type impl methods defined, where theFrom/Into
's call those, so there is no duplication of logic. I push on this because of the orphan rule, otherwise we could just impl all thesestd
traits ourselves: if they aren't defined in here, we'd have to wrap someorchard
types to achieve them. :/ I can make code snippet suggestions for them as needed, eg the one above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this is how I like to write typeclass instances in Haskell, and the analogy to traits is apt: write a function that is typed to whatever you're working on, and then use that function to provide for the generalized dispatch via the trait/typeclass.