Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new version to crates.io #100

Closed
dignifiedquire opened this issue Feb 20, 2019 · 4 comments
Closed

Publish new version to crates.io #100

dignifiedquire opened this issue Feb 20, 2019 · 4 comments

Comments

@dignifiedquire
Copy link

The version here is pretty outdated https://crates.io/crates/sapling-crypto, it would be great to have a new version published so we could depend on that instead of the git repo here.

Background: Trying to publish https://github.com/filecoin-project/rust-proofs to crates and are currently blocked on this dependency for doing so.

Thank you

@ebfull
Copy link
Collaborator

ebfull commented Feb 21, 2019

We currently depend on a forked version of the blake2-rfc crate which exists only in a git repository, so we can't push to crates.io. So either

  1. they accept Personalization support cesarb/blake2-rfc#9
  2. we fork it and publish a new crate
  3. we bring their crate into our tree

@str4d
Copy link
Contributor

str4d commented Mar 13, 2019

  1. We switch to another BLAKE2 implementation that has personalization support (e.g. the blake2 crate once Add support for Persona and Salt to Blake2 RustCrypto/hashes#75 is closed).

stefandeml pushed a commit to stefandeml/sapling-crypto that referenced this issue Jul 5, 2019
chore(ci): switch to custom docker image + better clippy config
@str4d
Copy link
Contributor

str4d commented Aug 26, 2019

Update: this will no longer happen, because we have successfully refactored this crate out of existence in zcash/librustzcash#104. Users of this crate should migrate to the next versions of bellman, zcash_primitives, and zcash_proofs when they are published (which should be soon - follow this milestone for progress).

@str4d str4d closed this as completed Aug 26, 2019
@str4d
Copy link
Contributor

str4d commented Aug 26, 2019

As an additional note, the Jubjub and Pedersen hash circuit code was temporarily moved into zcash_proofs (and the non-circuit code into zcash_primitives) because it requires additional refactoring. It will eventually move either into bellman or a companion crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants