Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP 316: clarify requirements, especially for Unified Viewing Keys #536

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

daira
Copy link
Collaborator

@daira daira commented Jul 12, 2021

This required introducing the Consumer definition, since a Consumer
of a UVK is not necessarily a Sender.

Signed-off-by: Daira Hopwood [email protected]

This required introducing the Consumer definition, since a Consumer
of a UVK is not necessarily a Sender.

Signed-off-by: Daira Hopwood <[email protected]>
@daira daira added this to the Core Sprint 2021-26 milestone Jul 12, 2021
@daira daira requested review from str4d and dconnolly July 12, 2021 12:20
Comment on lines -291 to -292
A Unified Address MUST contain at least one shielded Receiver
(Typecodes :math:`\geq \mathtt{0x02}`).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is moved to a later section.

Comment on lines -378 to -379
Encoding of Unified Full/Incoming Viewing Keys
----------------------------------------------
Copy link
Collaborator Author

@daira daira Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section was moved to above the list of requirements for both UAs and UVKs.

@daira daira merged commit 65ff47a into zcash:master Jul 13, 2021
@daira daira deleted the zip-316-clarification branch July 13, 2021 13:49
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants