Prefer project (worktree) tasks to language/global tasks in task::Spawn #21706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Викторов Иван Михайлович.
|
* Inventory::templates_from_settings() splitted to Inventory::global_templates_from_settings() and Inventory::worktree_templates_from_settings(). * list_tasks() now first collect tasks from worktree, second from language and lastly collects global tasks. * Tests for Inventory::list_tasks().
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
|
This seems like a pretty solid change. cc: @SomeoneToIgnore, you've been working on this recently right? What do you think :) |
Merged
SomeoneToIgnore
added a commit
that referenced
this pull request
Dec 14, 2024
lino-levan
pushed a commit
to the-code-editor-company/editor
that referenced
this pull request
Dec 16, 2024
…wn (zed-industries#21706) `Inventory::list_tasks()` in `project` crate now is ordered by task types. Worktree tasks comes first, language tasks second and global tasks last. That leads to `spawn_task_with_name()` from `task_ui` crate will find worktree task first, so it's possible to override global tasks at project level. * `Inventory::templates_from_settings()` splitted to `Inventory::global_templates_from_settings()` and `Inventory::worktree_templates_from_settings()`. * In tests function `list_tasks()` renamed to `list_tasks_sorted_by_last_used()`, because it call's `Inventory::used_and_current_resolved_tasks()`. Also added `list_tasks()` which calls `Inventory::list_tasks()`. Closes zed-industries#20987 Release Notes: - Fix task::Spawn to search for task name in project tasks first.
lino-levan
pushed a commit
to the-code-editor-company/editor
that referenced
this pull request
Dec 16, 2024
zed-industries#21706 was merged after zed-industries#22004 and the CI missed that. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inventory::list_tasks()inprojectcrate now is ordered by task types. Worktree tasks comes first, language tasks second and global tasks last.That leads to
spawn_task_with_name()fromtask_uicrate will find worktree task first, so it's possible to override global tasks at project level.Inventory::templates_from_settings()splitted toInventory::global_templates_from_settings()andInventory::worktree_templates_from_settings().In tests function
list_tasks()renamed tolist_tasks_sorted_by_last_used(), because it call'sInventory::used_and_current_resolved_tasks(). Also addedlist_tasks()which callsInventory::list_tasks().Closes #20987
Release Notes: