Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: Fix vim delete to line #23053

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

0x2CA
Copy link
Contributor

@0x2CA 0x2CA commented Jan 13, 2025

Closes #23024

Release Notes:

  • Fixed Vim dxG delete to line

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 13, 2025
@0x2CA 0x2CA changed the title vim:fix vim delete to line vim:Fix vim delete to line Jan 13, 2025
@maxdeviant maxdeviant changed the title vim:Fix vim delete to line vim: Fix vim delete to line Jan 13, 2025
@AaronFeickert
Copy link
Contributor

Thanks for the fix! Works great.

@ConradIrwin ConradIrwin enabled auto-merge January 14, 2025 02:53
@ConradIrwin
Copy link
Member

@0x2CA thanks for this! Looks like there was a bug in the code for handling G that led to it ignoring count for delete; I've fixed that and reverted the keymap change.

@ConradIrwin ConradIrwin added this pull request to the merge queue Jan 14, 2025
Merged via the queue into zed-industries:main with commit 03c99e3 Jan 14, 2025
13 checks passed
@0x2CA 0x2CA deleted the fix_vim_delete_to_line branch January 14, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vim "delete to line" deletes to end of buffer
3 participants