Omit gitignored files from context file picker #23777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by default, gitignored files can't be selected, and don't show up when filtering files by path or name, but `/file` still displayed them initially (useless if you can't select)
cla-bot
bot
added
the
cla-signed
marcospb19
force-pushed
the
prompt-editor-slash-file-omit-gitignored-entries
branch
from
f0e5dc8 to
a249bf3
Compare
marcospb19
changed the title
maxdeviant
reviewed
Jan 28, 2025
maxdeviant
approved these changes
Jan 28, 2025
|
thnks for the review :) |
marcospb19
deleted the
prompt-editor-slash-file-omit-gitignored-entries
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both
threadandprompt editorthe context file picker, gitignored files are hidden (as expected) when searching files by path, but they are still shown initially as you create the file picker.Plus, selecting gitignored files in the
prompt editoris bugged and collapses everything.This PR settles on not showing gitignored files to solve these inconsistencies.
Release Notes: