Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more LSP data when falling back to regular completions label #23909

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

SomeoneToIgnore
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore commented Jan 30, 2025

Part of #7559
Closes #23590
Closes https://x.com/steeve/status/1865129235536568555

Before:

before

After:

after

The list obviously needs some solution for the cut-off part of the completion label, but this is the reality for all extensions' completions too, so one step at a time.

Release Notes:

  • Improved default completion label fallback

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 30, 2025
@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) January 30, 2025 14:37
@SomeoneToIgnore SomeoneToIgnore merged commit 9e45557 into main Jan 30, 2025
12 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/better-completions-fallback branch January 30, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion labels not showing imports
1 participant