Fix slow focus transitions to the terminal panel #24172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
mikayla-maki
changed the title
mikayla-maki
requested review from
ConradIrwin
and removed request for
ConradIrwin
|
On looking deeper into this PR, I think we should actually fix the GPUI issue. |
|
Turns out the GPUI changes where easier than I thought! Edit: clicking the right buttons on github however... |
mikayla-maki
force-pushed
the
fix-delayed-focus-in-terminal-panel
branch
from
7a17b6f to
44823ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This long standing bug was caused by
Pane's focus_in handler bouncing the focus to another handle.Because focus resolution happens after a frame has been rendered, the only way to deal with this case is to schedule another frame to be redrawn. However, we where suppressing all window refreshes that occur during a focus transfer, causing this focus change to be completely missed. However, changing this behavior can lead to infinite notify loops, due to drawing a frame causing another to be rendered.
This PR fixes this problem narrowly by adding an
on_next_frame()callback in the pane's focus handle, so that the focus changes take effect almost immediately. But only for this case, where we know it doesn't cause infinite notify loops.TODO:
Release Notes: