Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build media and live-kit in test-mode on non-MacOS #6859

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Jan 27, 2024

Build media and live-kit in test-mode on non-MacOS (Related to #5391 #5395 #5394)

This makes it possible to build the media and live-kit crates on non-MacOS

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 27, 2024
Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !
I was removing some parts of the code to get it to build, but your solution seems like the right one 💯

@williamdes williamdes mentioned this pull request Jan 27, 2024
@maxdeviant maxdeviant changed the title fix: build media and live-kit in test-mode on non-MacOS Build media and live-kit in test-mode on non-MacOS Jan 27, 2024
Copy link
Contributor

@mikayla-maki mikayla-maki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mikayla-maki mikayla-maki merged commit 2c834c2 into zed-industries:main Jan 30, 2024
4 checks passed
@aminya aminya mentioned this pull request Jan 30, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants