Fix when input redirection becomes visible. #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
requested changes
Sep 30, 2024
rsmmr
force-pushed
the
topic/robin/gh-1842-offset
branch
from
5bdae0e to
ea2deb1
Compare
With `&parse-at/from` we were updating the internal state on our current position immediately, meaning they were visible already when evaluating other attributes on the same field afterwards, which is unexpected. Closes #1842.
rsmmr
force-pushed
the
topic/robin/gh-1842-offset
branch
from
ea2deb1 to
2eeffa6
Compare
bbannier
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
&parse-at/fromwe were updating the internal state on ourcurrent position immediately, meaning they were visible already when
evaluating other attributes on the same field afterwards, which is
unexpected.
Closes #1842.