Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider.py: change argument name from config to state #4

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

brncsk
Copy link

@brncsk brncsk commented Jun 30, 2023

This fixes the provider wrt. the following Sentry commit:

getsentry/sentry@326315f#diff-e0494c56201878812ba2d58e03a3e6310b0da0b3ed3f5c8ee6c0c9fa243d54aaR858

...which changed the invocation to use a kwarg, causing a mismatch between sentry and sentry-auth-gitlab.

This fixes the provider wrt. the following Sentry commit:

getsentry/sentry@326315f
@zekker6 zekker6 merged commit 2cd9e21 into zekker6:master Sep 8, 2023
@zekker6
Copy link
Owner

zekker6 commented Sep 8, 2023

@brncsk Thank you for the fix!
Also sorry for a long delay, completely missed this PR somehow.

@zekker6
Copy link
Owner

zekker6 commented Sep 8, 2023

FYI: this was released at 0.3.0 - https://pypi.org/project/sentry-auth-gitlab-v2/0.3.0/

@brncsk
Copy link
Author

brncsk commented Sep 8, 2023

@brncsk Thank you for the fix!

Also sorry for a long delay, completely missed this PR somehow.

No worries, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants