provider.py: implement missing abstract methods #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit trivially implements `get_client_id()` and `get_client_secret()`. This prevents Sentry's `web` container from dying w/ HTTP 500s while serving requests with the following error: `TypeError: Can't instantiate abstract class GitLabOAuth2Provider with abstract methods get_client_id, get_client_secret`
|
@zekker6 Sorry, seems like there's another minor change to keep up with the Sentry codebase changing 😅. I really can't pinpoint the Sentry commit causing this, but adding these two methods to |
|
@brncsk Thank you for the fix! |
|
Released this as v0.3.1, could you verify if it works with your Sentry installation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit trivially implements
get_client_id()andget_client_secret().This prevents Sentry's
webcontainer from dying w/ HTTP 500s while serving requests with the following error:TypeError: Can't instantiate abstract class GitLabOAuth2Provider with abstract methods get_client_id, get_client_secret