Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to open directory from strider - filepicker #3267

Closed
matiux opened this issue Apr 16, 2024 · 19 comments
Closed

Unable to open directory from strider - filepicker #3267

matiux opened this issue Apr 16, 2024 · 19 comments

Comments

@matiux
Copy link

matiux commented Apr 16, 2024

stty size: 57 202
zellij: 0.40.0
uname -av: Linux iuxhome 6.8.5-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 11 Apr 2024 01:47:33 +0000 x86_64 GNU/Linux
zsh --version: 5.9 (x86_64-pc-linux-gnu)
ohmyzsh
powerlevel10k

Step to reproduce:

Add key binding

bind "Alt f" {
   LaunchPlugin "filepicker" {
      close_on_selection true
   };
}

Press Alt + f to open the filepicker, than,navigate to desired folder:

Screenshot_20240416_152742

Press TAB to select desired folder, in my example zellij:

Screenshot_20240416_153034

Press enter to open folder in the right panel, but nothing happens. The position in the right panel doesn't change. Is this behavior correct?

P.s. However, if I select a file, it opens without problems

@cyayon
Copy link

cyayon commented Apr 16, 2024

hi,
same issue here

@rishikanthc
Copy link

just updated zellij and I'm having this issue too

@quanhua92
Copy link

quanhua92 commented Apr 17, 2024

I am using Ubuntu 22.04 and having this issue as well. I install Zellij from the main branch

@imsnif
Copy link
Member

imsnif commented Apr 17, 2024

To those experiencing this issue: if you set the default_shell in the config to something (eg. bash) and then start a new session, does it work?

@quanhua92
Copy link

@imsnif Setting default_shell fixes the bug for me. My $SHELL is /bin/bash, I set the default_shell to bash

@imsnif
Copy link
Member

imsnif commented Apr 17, 2024

Thanks @quanhua92, I'll fix this in a patch soon. For now, at least we have a temporary workaround.

@matiux
Copy link
Author

matiux commented Apr 17, 2024

@imsnif, tryed with default_shell "zsh" and default_shell "/usr/bin/zsh" but it stil doesn't work form me.

echo $SHELL
/usr/bin/zsh

@matiux
Copy link
Author

matiux commented Apr 17, 2024

maybe problems with zsh / oh-my-zsh / powerlevel10k ?

@matiux
Copy link
Author

matiux commented Apr 17, 2024

I've just discovered that even though I'm using zsh, setting default_shell "bash" solves my problem... Is it correct?

@matiux
Copy link
Author

matiux commented Apr 17, 2024

@imsnif seems to be some problems with zsh. At the top of my zsh config file I have this, I don't know if it could matter:

if [[ ! -v ZELLIJ || ( -v ZELLIJ && $ZELLIJ -eq 1 ) ]]; then
	zellij attach --create default-session
fi

to attach zellij to a specific existing session.

setting default_shell "bash" obviously makes me lose zsh when I open panels. On the other hand setting default_shell "zsh" introduces a strange behavior. Please, see attached video. As you can see, pressing enter to open a folder, closes the filepicker and breaks the layout. (with default_shell "zsh")

Screencast_20240417_192108.webm

@rockboynton
Copy link

default_shell "fish" works as a workaround for me

@matiux
Copy link
Author

matiux commented Apr 19, 2024

@rockboynton are you using zsh?

According to the documentation, fish should be the default shell. Even when commented out, the behavior should remain the same.

@rockboynton
Copy link

@matiux no, I have my $SHELL set as fish and the filepicker (strider) worked before v0.40 without setting this config, but now I have to explicitly set it for it to work

@matiux
Copy link
Author

matiux commented Apr 19, 2024

@rockboynton the problem seems to be related to zsh. I would like to have more feedback with zsh besides my own

@matiux
Copy link
Author

matiux commented Apr 24, 2024

Hi @imsnif, any news or suggestion ?

@imsnif
Copy link
Member

imsnif commented Apr 24, 2024

Hi @matiux - I appreciate that you really want this problem fixed, but please don't tag me. This is a large project and I unfortunately do not have the capacity to provide user support to all who need it. I am just one person.

Please see my previous comment about this issue, your problem (given that it happens only in one shell) almost certainly has to do with your environment and the way you launch Zellij.

If you'd like help getting to the bottom of it, please go to one of our dedicated support platforms (Discord and to a lesser extend Matrix).

@matiux
Copy link
Author

matiux commented Apr 24, 2024

My apologies for tagging you. I just thought you might have a better understanding of the project. By the way, to lunch zellij, I simply put this at the beginning of the ~/.zshrc file

if [[ ! -v ZELLIJ || ( -v ZELLIJ && $ZELLIJ -eq 1 ) ]]; then
        zellij attach --create default-session
fi

is it a wrong approach?

@imsnif
Copy link
Member

imsnif commented Apr 24, 2024

Fixed in #3267 - will release a patch version with this and other fixes in the near future.

@imsnif imsnif closed this as completed Apr 24, 2024
@matiux
Copy link
Author

matiux commented Apr 24, 2024

Thanks. Hope this patch will fix also for zsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants