Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy default.yaml config from assets to example in the release process #733

Closed
qwerty01 opened this issue Sep 20, 2021 · 4 comments · Fixed by #736
Closed

Copy default.yaml config from assets to example in the release process #733

qwerty01 opened this issue Sep 20, 2021 · 4 comments · Fixed by #736
Labels
suspected bug

Comments

@qwerty01
Copy link

The repository contains a default.yaml in the example directory, however it seems to be out of date with the current defaults (it still has ctrl+r for resize and doesn't have a bind for switching to session mode).

For anyone looking for an up-to-date default config.yaml, zellij setup --dump-config with no configuration file works.
@a-kenji
Copy link
Contributor

a-kenji commented Sep 20, 2021

Thank you for filing this issue!
Do you think we should remove, or rename the file?
It is in the example directory, so it shows some examples in how you could
configure zellij.

The actual default config file is here: https://github.com/zellij-org/zellij/blob/main/zellij-utils/assets/config/default.yaml .

Maybe we could even copy the default config file to the examples directory once a version is released?

@qwerty01
Copy link
Author

If it's just an example, maybe renaming would be the best option, otherwise copying the default config when a version is released would probably be better.

I'd personally prefer copying the default file on a new release, since it's a great starting point for a new config.

@a-kenji
Copy link
Contributor

a-kenji commented Sep 20, 2021

I agree this could be a good solution,
I will change the title of the issue to make it more actionable.

  • Add copying the default.yaml from the assets/config directory to the example/config directory
    to the release process (Makefile)

@a-kenji a-kenji changed the title Default config file out of date Add copying the default.yaml config from assets to example to the release process Sep 20, 2021
@a-kenji a-kenji changed the title Add copying the default.yaml config from assets to example to the release process Copy default.yaml config from assets to example in the release process Sep 20, 2021
@qwerty01
Copy link
Author

Oh another small note if this is ever revisited and the decision is changed to renaming the file: the documentation for keybinds (https://zellij.dev/documentation/keybindings.html) points to that file for the default keybinds, so it would need to be changed

a-kenji added a commit to a-kenji/zellij that referenced this issue Sep 21, 2021
@a-kenji
feature(release): Copy default config to the examples folder on release
c7286d1 
fixes zellij-org#733
@a-kenji a-kenji mentioned this issue Sep 21, 2021
Merged
a-kenji added a commit that referenced this issue Sep 21, 2021
@a-kenji
feature(release): Copy default config to the examples folder on relea…
8cf93d8 
…se (#736)

fixes #733
imsnif added a commit that referenced this issue Sep 27, 2021
@takezyou @TheLostLambda
@a-kenji @spacemaison @imsnif
feat(ui): The status bar indicates that the panes are full screen and…
4632e90 
… how many hidden panes are (#450)

* fix(ui): offset content after viewport construction

* Added the feature to display fullscreen information on the second line of the status-bar.

* fix(strider): update host mount-point

* fix(plugin): create missing data directories as needed

* feat(layout): specify only tab name in `tabs` section (#722)

Allow specifying only the tab name in the `tabs` section

- For example this is now possible:
```
tabs:
  - name: first
    parts:
      - direction: Vertical
      - direction: Vertical
  - name: second
  - name: third
```
  For that the tab section defaults the direction to
  `direction::Horizontal`

- Adds an error upon specifying a tab name inside the `parts` section
  of the tab-layout

* docs(changelog): Solely name tab in `tabs` section

* feature(release): Copy default config to the examples folder on release (#736)

fixes #733

* docs(changelog): Copy example config on release

* Update default config (#737)

* feat(plugin): add manifest to allow for plugin configuration (#660)

* feat(plugins-manifest): Add a plugins manifest to allow for more configuration of plugins

* refactor(plugins-manifest): Better storage of plugin metadata in wasm_vm

* fix(plugins-manifest): Inherit permissions from run configuration

* refactor(plugins-manifest): Rename things for more clarity

- The Plugins/Plugin structs had "Config" appended to them to clarify
  that they're metadata about plugins, and not the plugins themselves.

- The PluginType::OncePerPane variant was renamed to be just
  PluginType::Pane, and the documentation clarified to explain what it
  is.

- The "service" nomenclature was completely removed in favor of
  "headless".

* refactor(plugins-manifest): Move security warning into start plugin

* refactor(plugins-manifest): Remove hack in favor of standard method

* refactor(plugins-manifest): Change display of plugin location

The only time that a plugin location is displayed in Zellij is the
border of the pane. Having `zellij:strider` display instead of just
`strider` was a little annoying, so we're stripping out the scheme
information from a locations display.

* refactor(plugins-manifest): Add a little more documentation

* fix(plugins-manifest): Formatting

Co-authored-by: Jesse Tuchsen <not@disclosing>

* chore(docs): update changelog

* feat(sessions): mirrored sessions (#740)

* feat(sessions): mirrored sessions

* fix(tests): input units

* style(fmt): make rustfmt happy

* fix(tests): make mirrored sessions e2e test more robust

* refactor(sessions): remove force attach

* style(fmt): rustfmtify

* docs(changelog): update change

* fix(e2e): retry on all errors

Co-authored-by: Brooks J Rady <[email protected]>
Co-authored-by: a-kenji <[email protected]>
Co-authored-by: spacemaison <[email protected]>
Co-authored-by: Jesse Tuchsen <not@disclosing>
Co-authored-by: Aram Drevekenin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suspected bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(release): Copy default config to the examples folder on release a-kenji/zellij
2 participants
@qwerty01 @a-kenji