Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid assignment of client_id #1052

Merged
merged 3 commits into from
Feb 23, 2022
Merged

fix: invalid assignment of client_id #1052

merged 3 commits into from
Feb 23, 2022

Conversation

jaeheonji
Copy link
Member

@jaeheonji jaeheonji commented Feb 10, 2022

화면 캡처 2022-02-10 163335

This PR is related the invalid assignment of client_id.
As the above log, the problem occurs when attaching to a session.

The cause of the problem is the assert_socket function, which checks whether the socket is connected before attaching.
Ideally, this should work like this:
mermaid-diagram-20220210165805

But, currently like this:
mermaid-diagram-20220210170028

To solve this problem, assert_socket has to wait for a message from the server.

@jaeheonji jaeheonji requested a review from imsnif February 11, 2022 08:49
@jaeheonji jaeheonji merged commit a489194 into zellij-org:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant