-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Default Keybinds in Resize Mode #440 #441
Conversation
6f0e861
to
2a70552
Compare
@a-kenji - I think this is not right. In Pane mode it needs to be normal arrows (not alt). This is also true to Tab and Scroll. Normal arrows should behave just like hjkl in those cases. Alt should remain the same in all modes |
(the alt case is a little weird and doesn't work 100% when another non-alt shortcut with the same key is bound... so it's okay if they just work in normal mode actually) Sorry for being hectic, just wanted to chime in before the merge :) |
Thanks for checking over this! This is the current pane mode:
This is the current resize mode:
|
@imsnif Ah, now I understand what you mean with the alt. |
True, my bad! I only looked at it very quickly :) Sorry! Additionally though: the arrow keys don't work in tab/scroll mode. Maybe we can also fix them as part of this? |
I like that idea, In Tab Mode: Left/Right: Next/Previous Tab? Or other ideas? |
That sounds cool :) I would just be happy if scroll up/down arrow and tab left/right arrows work - but these also sound great. |
2a70552
to
49698df
Compare
Closes zellij-org#440 Changes arrow keybinds from switching focus to resizing. Add arrow parity keybinds to scroll and tab modes.
49698df
to
118e5a1
Compare
I tried adding the parity to the scroll and tab mode, could you please do a sanity check on that? |
LGTM! 👍 |
Closes #440
Changes arrow keybinds from switching focus
to resizing.