refactor(tabs): lay down infrastructure for multiple users #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/imsnif/mosaic into multiple-users-screen-structs
…saic-org/mosaic into multiple-users-screen-structs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the work to support multiple users with multiple cursors. This PR changes
Tabto support multiple active panes, and update all related methods.As previously done with switching between tabs, currently the code "administratively" keeps all clients synchronized to the same pane. This will be changed in future PRs once we update all the rest of the things we need to make this feature happen (specifically the UI and the plugins).
EDIT:
Almost forgot - this PR also completely changes the e2e infrastructure (specifically the remote test runner) so that it's now asynchronous with regards to reading/writing from the ssh channel. This is to support the newly added test that tests mirrored sessions. I hope it won't make things unstable again :)