Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert lib to synchronous operation. #126

Merged
merged 3 commits into from
Jul 7, 2016
Merged

Convert lib to synchronous operation. #126

merged 3 commits into from
Jul 7, 2016

Conversation

STRML
Copy link
Contributor

@STRML STRML commented Jul 7, 2016

Optional callback is still functional but uses process.nextTick()
to avoid accidentally-synchronous operation.

Previous versions had an async API but actually operated
synchronously.

Fixes #125

@STRML
Convert lib to synchronous operation.
1b3bcf5 
Optional callback is still functional but uses process.nextTick()
to avoid accidentally-synchronous operation.

Previous versions had an async API but actually operated
synchronously.
@knownasilya
Copy link
Collaborator

Looks beautiful! Could you also update the README and https://github.com/zemirco/json2csv/blob/master/index.d.ts? Thanks!

@coveralls
Copy link

coveralls commented Jul 7, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 1b3bcf5 on STRML:syncAsync into eb0bb6e on zemirco:master.

@STRML
Copy link
Contributor Author

STRML commented Jul 7, 2016

Good to go @knownasilya.

@knownasilya
Copy link
Collaborator

I'll merge and publish once all the checks are green.

@coveralls
Copy link

coveralls commented Jul 7, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 5d9ba51 on STRML:syncAsync into eb0bb6e on zemirco:master.

@coveralls
Copy link

coveralls commented Jul 7, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 5d9ba51 on STRML:syncAsync into eb0bb6e on zemirco:master.

@knownasilya knownasilya merged commit b91158b into zemirco:master Jul 7, 2016
knownasilya pushed a commit that referenced this pull request Jul 7, 2016
v3.6.0
765cd9c 
* Make callback optional
* Make callback use `process.nextTick`, so it's not sync

See #126 and #125

Thanks @STRML!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@STRML @knownasilya @coveralls