Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sync cli and lib #217

Merged
merged 6 commits into from
Jan 19, 2018
Merged

Feature/sync cli and lib #217

merged 6 commits into from
Jan 19, 2018

Conversation

juanjoDiaz
Copy link
Collaborator

Following #216

Since we are already breaking the API.

I've also renamed:

  • del -> delimiter
  • quotes -> quote
    in oder to match the cli options

@coveralls
Copy link

coveralls commented Jan 18, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 20b05b5 on juanjoDiaz:feature/sync_cli_and_lib into 3359e8d on zemirco:master.

@knownasilya
Copy link
Collaborator

I merged the other PR, could you resolve the conflicts that were created? Thanks!

@juanjoDiaz
Copy link
Collaborator Author

Should be good now :)

@coveralls
Copy link

coveralls commented Jan 18, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 787a2f0 on juanjoDiaz:feature/sync_cli_and_lib into f053c8b on zemirco:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 672d7d8 on juanjoDiaz:feature/sync_cli_and_lib into f053c8b on zemirco:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 672d7d8 on juanjoDiaz:feature/sync_cli_and_lib into f053c8b on zemirco:master.

@coveralls
Copy link

coveralls commented Jan 18, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 672d7d8 on juanjoDiaz:feature/sync_cli_and_lib into f053c8b on zemirco:master.

@knownasilya knownasilya merged commit 5e402dc into zemirco:master Jan 19, 2018
@juanjoDiaz juanjoDiaz deleted the feature/sync_cli_and_lib branch February 4, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knownasilya knownasilya knownasilya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanjoDiaz @coveralls @knownasilya