Compatibility with Rails 5.2 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschambacher
force-pushed
the
pschambacher/rails5.2
branch
from
af64faa to
aa56221
Compare
grosser
reviewed
Dec 8, 2017
test/helper.rb
Outdated
| @@ -23,7 +23,7 @@ module ARHPTestSetup | |||
|
|
|||
| def arhp_create_models | |||
| return if Object.const_defined?('Test1') | |||
| eval <<-EOL | |||
| eval <<-CREATE_MODELS | |||
There was a problem hiding this comment.
use <<-RUBY to get syntax highlighting
There was a problem hiding this comment.
I'm pretty sure that Rubocop won't like that
grosser
approved these changes
Dec 8, 2017
pschambacher
force-pushed
the
pschambacher/rails5.2
branch
from
aa56221 to
0b643eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @zendesk/zendesk-rails-upgraders