This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Remove the concept of dry_run
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I went to add some notes to a changelog only to realise we don't have one yet. I'll whip one up :) EDIT: #65 - I will rebase on top of that once it's in master and add a note. |
bquorning
reviewed
Mar 31, 2020
The flag was false by default, adds complexity to the code and can be confused with the other disabled states `use_global_uid`, the global_uid_options[:disabled] and `global_uid_disabled` on the model. Use `global_uid_options[:disabled]` if you want to disable the functionality. There's a performance spec for benchmarking.
mriddle
force-pushed
the
mriddle-remove-dry-run
branch
from
7bd96a2 to
3d9f44f
Compare
|
I think we need to check for |
bquorning
approved these changes
Apr 1, 2020
|
With the changes prosed here and the others in #63, I was going to suggest that we release these under a major version bump as the validations are also a breaking change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag was false by default. It adds complexity to the code and can be confused with the other disabled states
use_global_uid, theglobal_uid_options[:disabled]option andglobal_uid_disabledon the model.Use
global_uid_options[:disabled]if you want to disable the functionality. There's a performance spec for benchmarking included in dc1f998