This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Update README #67
Merged
Update README #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows you to run specific test scenarios, useful when iterating on a particular feature.
mriddle
commented
Apr 1, 2020
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| The `increment_by` value configured here does not dictate the value on your alloc server and must remain in sync with the value of [`auto_increment_increment`](https://dev.mysql.com/doc/refman/5.6/en/replication-options-master.html#sysvar_auto_increment_increment) |
There was a problem hiding this comment.
This disclaimer and the references below it will be updated once the validation work in #63 is merged
bquorning
reviewed
Apr 1, 2020
Mocha deprecation warning at test_helper.rb:7 `require': Require 'mocha/test_unit', 'mocha/minitest' or 'mocha/api' instead of 'mocha/setup'.
Tweaks: * Add more detail to how the gem works in the summary section * Set `increment_by` value to what we're using as the default * Disclaimer that `increment_by` doesn't do anything, the configuration must be done on the MySQL server itself. * Updated outdated testing steps * Moved the testing section to the bottom, it was in the middle of the installation and configuration instructions
mriddle
force-pushed
the
mriddle-misc-updates
branch
from
7196931 to
8130ce7
Compare
bquorning
approved these changes
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small changes
pryandminitest-lineas a development dependency which I've found invaluable while working on this gem