This repository has been archived by the owner on Nov 23, 2024. It is now read-only.
Remove unused and often misleading options
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mriddle
force-pushed
the
mriddle-remove-unused-options
branch
from
70f9348 to
c639309
Compare
|
Sorry for being pedantic, but could we possibly split this into two commits: One that starts using |
|
@bquorning Sure thing! EDIT: You're not being pedantic by the way, I appreciate the fresh set of eyes and understand where you're coming from. In one commit it was unclear that the options were unused. In two commits, it's easier to follow my logic. |
mriddle
force-pushed
the
mriddle-remove-unused-options
branch
from
c639309 to
70b1957
Compare
bquorning
reviewed
Apr 2, 2020
bquorning
approved these changes
Apr 2, 2020
The options passed in are just the `global_uid_options`, refer to them directly to make the code easier to follow.
mriddle
force-pushed
the
mriddle-remove-unused-options
branch
from
c6fd83c to
9f51314
Compare
In the following cases we were passing options around but never using them, introduced in the original implementation but never used. I found them misleading as whatever you passed in would ultimately be ignored. I've removed them so the code is more explicit and hopefully a little less confusing.
bquorning
approved these changes
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following cases we were passing options around but never using them, leftover from a previous implementation but never used. I found them misleading as whatever you passed in would ultimately be ignored.
I've removed them so the code is more explicit and hopefully a little less confusing.