Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make verify_hostname settable for ssl contexts #828

Merged
merged 2 commits into from
May 18, 2020
Merged

Make verify_hostname settable for ssl contexts #828

merged 2 commits into from
May 18, 2020

Conversation

lairen
Copy link
Contributor

@lairen lairen commented May 11, 2020

Resolves #826

@dasch

dasch
dasch approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@dasch dasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the README? Then I'll happily merge 👍

@lairen lairen force-pushed the verify-hostname branch from 41f0cda to dd82cb3 Compare May 15, 2020 15:31
@lairen lairen force-pushed the verify-hostname branch from dd82cb3 to c352cd7 Compare May 15, 2020 15:39
@lairen
Copy link
Contributor Author

lairen commented May 15, 2020

@dasch Updated!

@dasch dasch merged commit 48b16ee into zendesk:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasch dasch dasch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssl_verify_hostname var is ignored unless also specifying a ca_cert var
2 participants
@lairen @dasch