Merge pull request #4115 from zendesk/awoo/release-log-project

Log project name when creating a release
zendesk · Aug 26, 2024 · 27d9522 · 27d9522
2 parents 5282f8d + a44f65d
commit 27d9522
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/app/controllers/integrations/base_controller.rb b/app/controllers/integrations/base_controller.rb
@@ -18,8 +18,8 @@ def create
       create_release = project.create_release?(branch, service_type, service_name)
       record_log(
         :info,
-        "Create release for branch [#{branch}], service_type [#{service_type}], service_name [#{service_name}]: " \
-        "#{create_release}"
+        "Create release for project [#{project.name}], branch [#{branch}], service_type [#{service_type}], " \
+        "service_name [#{service_name}]: #{create_release}"
       )
       release = find_or_create_release if create_release
     else

diff --git a/test/controllers/integrations/base_controller_test.rb b/test/controllers/integrations/base_controller_test.rb
@@ -109,7 +109,8 @@ class BaseTestController < Integrations::BaseController # rubocop:disable Lint/C
       post :create, params: {test_route: true, token: token, foo: "bar"}
       assert_response :success
       result = WebhookRecorder.read(project)
-      log = "INFO: Create release for branch [master], service_type [ci], service_name [base_test]: true\n"
+      log = "INFO: Create release for project [Foo], branch [master], service_type [ci], " \
+            "service_name [base_test]: true\n"
 
       project.reload
       result.fetch(:log).must_equal log
@@ -192,7 +193,7 @@ class BaseTestController < Integrations::BaseController # rubocop:disable Lint/C
         post :create, params: {test_route: true, token: token}
 
         expected_messages = <<~MESSAGES
-          INFO: Create release for branch [master], service_type [ci], service_name [base_test]: true
+          INFO: Create release for project [Foo], branch [master], service_type [ci], service_name [base_test]: true
           INFO: Deploying #{deploy1.id} to Staging
           INFO: Deploying #{deploy2.id} to Production
         MESSAGES
@@ -221,7 +222,7 @@ class BaseTestController < Integrations::BaseController # rubocop:disable Lint/C
         post :create, params: {test_route: true, token: token, includes: 'status_urls'}
 
         expected_messages = <<~MESSAGES
-          INFO: Create release for branch [master], service_type [ci], service_name [base_test]: true
+          INFO: Create release for project [Foo], branch [master], service_type [ci], service_name [base_test]: true
           INFO: Deploying #{deploy1.id} to Staging
           INFO: Deploying #{deploy2.id} to Production
         MESSAGES
@@ -241,7 +242,7 @@ class BaseTestController < Integrations::BaseController # rubocop:disable Lint/C
         post :create, params: {test_route: true, token: token}
 
         message = <<~MSG
-          INFO: Create release for branch [master], service_type [ci], service_name [base_test]: true
+          INFO: Create release for project [Foo], branch [master], service_type [ci], service_name [base_test]: true
           ERROR: Failed deploying to Staging: Stage is locked
           INFO: Deploying #{Deploy.first.id} to Production
         MSG