Add fossa scan to ensure we can release under apache v2 #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what is this and why is it needed ? |
grosser
reviewed
Aug 24, 2018
.travis.yml
Outdated
| @@ -4,7 +4,7 @@ cache: | |||
| directories: | |||
| - tmp/rubocop_cache | |||
| - node_modules | |||
| sudo: false | |||
| sudo: required | |||
There was a problem hiding this comment.
only switch for the new job
grosser
reviewed
Aug 24, 2018
.travis.yml
Outdated
| @@ -25,3 +25,13 @@ before_script: | |||
| - mysql -u root -e 'set GLOBAL innodb_file_format = "barracuda"' | |||
| - mysql -u root -e 'GRANT ALL ON *.* TO 'travis'@'localhost';' | |||
| script: bundle exec rake $TASK | |||
| jobs: | |||
grosser
reviewed
Aug 24, 2018
.travis.yml
Outdated
| script: | ||
| - fossa init | ||
| - fossa analyze --branch master | ||
| env: "" |
There was a problem hiding this comment.
put something like TASK=FOSSA here so that it shows nicely in the build overview page
grosser
reviewed
Aug 24, 2018
.travis.yml
Outdated
| jobs: | ||
| include: | ||
| - stage: fossa | ||
| before_script: curl -H 'Cache-Control:no-cache' https://raw.githubusercontent.com/fossas/fossa-cli/master/install.sh | bash |
There was a problem hiding this comment.
maybe better to put init here since we only want the analyze output in the job output
grosser
force-pushed
the
plonergan/fossa
branch
from
7ece678 to
ee21dcb
Compare
grosser
changed the title
grosser
force-pushed
the
plonergan/fossa
branch
from
467d38a to
1b97555
Compare
... so ask the fossa guys how long scans usually take ... |
grosser
force-pushed
the
plonergan/fossa
branch
from
daaf049 to
df61668
Compare
|
need fossas/fossa-cli#247 to be resolved first :( |
grosser
force-pushed
the
plonergan/fossa
branch
from
2cb3084 to
f2fbc75
Compare
grosser
approved these changes
Sep 26, 2018
|
@ragurney looks good ? |
ragurney
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
/cc @zendesk/samson