Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support all kubernetes resources by default #2981

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

eatwithforks
Copy link
Contributor

/cc @zendesk/samson @zendesk/compute

@eatwithforks eatwithforks requested review from grosser and a team as code owners October 5, 2018 22:59
@grosser
Copy link
Contributor

grosser commented Oct 6, 2018

  • template_filler to_hash will need some rework to support generic kinds ... atm we are not setting name or basic info if no kind matches ... atm it's kinda broken since it does not apply name that can be an independent PR too ... and we figure out what the fallout will be from that change
  • release_doc verification_template should run verification on all kinds and maybe exclude some that are too hard
  • role_validator needs to validate that there is exactly 1 primary kind or all of the deploy logic will break down

@eatwithforks eatwithforks force-pushed the jylee/deletedefaultclasses branch 2 times, most recently from f6fb944 to 59700d3 Compare October 8, 2018 20:55
@eatwithforks eatwithforks force-pushed the jylee/deletedefaultclasses branch from b92f947 to 8ba98a3 Compare October 8, 2018 21:10
@eatwithforks eatwithforks merged commit b216397 into master Oct 8, 2018
@eatwithforks eatwithforks deleted the jylee/deletedefaultclasses branch October 8, 2018 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants