Bump Node.js (18.19.1 → 18.20.5), Ruby (3.2.5 → 3.3.6), Rubocop (1.42.0 → 1.70.0), sqlite3 (1.6.9 → 1.7.3), rails-html-sanitizer (1.6.0 → 1.6.2) #4123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
changed the title
orien
force-pushed
the
dependency-update
branch
from
b219945 to
dfef7fc
Compare
orien
changed the title
orien
force-pushed
the
dependency-update
branch
from
dfef7fc to
ae4824a
Compare
orien
force-pushed
the
dependency-update
branch
from
5b617e9 to
9d8472d
Compare
orien
changed the title
orien
force-pushed
the
dependency-update
branch
from
9d8472d to
9558992
Compare
grosser
reviewed
Jan 11, 2025
| @@ -4,3 +4,4 @@ | |||
| # - leave file with `ignore: []` if ignore list is empty | |||
| ignore: | |||
| - CVE-2024-6484 # ignore until a patch is available https://github.com/advisories/GHSA-9mvj-f7w8-pvh2 | |||
| - CVE-2024-54133 # ignore until Rails is upgraded to >= 7.0 | |||
There was a problem hiding this comment.
FYI got a PR for that read here #4120
... we are almost done with hosting samson ourselves, so if you can verify it works we can merge that too
grosser
reviewed
Jan 11, 2025
| @@ -5,7 +5,7 @@ def user_project_role_radio(user, role_name, role_id, user_project_role_id) | |||
| global_access = (user.role_id >= role_id.to_i) | |||
| disabled = (user.role_id > role_id.to_i) | |||
| project_access = (user_project_role_id.to_i >= role_id.to_i) | |||
| checked = (global_access || project_access) | |||
| checked = global_access || project_access | |||
There was a problem hiding this comment.
FYI kinda like these assignment wrappers since it makes things clearer, but 🤷
grosser
reviewed
Jan 11, 2025
| @@ -20,7 +20,7 @@ def change | |||
| OutboundWebhook.find_each do |wh| | |||
| OutboundWebhookStage.create!(stage_id: wh.stage_id, outbound_webhook_id: wh.id) do |o| | |||
| o.created_at = wh.created_at | |||
| o.updated_at = o.updated_at | |||
| o.updated_at = wh.updated_at | |||
grosser
reviewed
Jan 11, 2025
| @@ -55,7 +55,7 @@ def parsed_template | |||
| def validate_template | |||
| return errors.add :template, "needs to be set" if template.blank? | |||
| return errors.add :template, "needs to be a Hash" unless parsed_template.is_a?(Hash) | |||
| return errors.add :template, "needs metadata.labels.team" unless parsed_template.dig("metadata", "labels", "team") | |||
| errors.add :template, "needs metadata.labels.team" unless parsed_template.dig("metadata", "labels", "team") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Node.js and Ruby.
Rubocop needed a bump to support Ruby 3.3, which resulted in a number of style corrections which I've accommodated. FYI: I put each Rubocop resolution change in a separate commit for easy review.
sqlite3 also needed a bump to support Ruby 3.3.
rails-html-sanitizer got a bump to resolve CVE-2024-53985, CVE-2024-53986, CVE-2024-53987, CVE-2024-53988 and CVE-2024-53989